Skip to content

London | 26 - ITP-Sep | Ebrahim Moqbel | Sprint 3 | Implement and ewrite tests - #1609

Open
Ebrahim-Moqbel wants to merge 11 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework/sprint-3-implement-and-rewrite
Open

London | 26 - ITP-Sep | Ebrahim Moqbel | Sprint 3 | Implement and ewrite tests#1609
Ebrahim-Moqbel wants to merge 11 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework/sprint-3-implement-and-rewrite

Conversation

@Ebrahim-Moqbel

@Ebrahim-Moqbel Ebrahim-Moqbel commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1059

Changelist

completed the implement and rewrite tests directory

Questions

N/A

@github-actions

This comment has been minimized.

Sign in to view
@Ebrahim-Moqbel Ebrahim-Moqbel added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 4, 2026
@Khantdotcom Khantdotcom added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 5, 2026
Khantdotcom
Khantdotcom suggested changes Sep 5, 2026
View reviewed changes

@Khantdotcom Khantdotcom left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fix : Typo in 3-get-card-value.js

Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated
@Khantdotcom Khantdotcom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 5, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026
@Ebrahim-Moqbel

Ebrahim-Moqbel commented Sep 14, 2026

Copy link
Copy Markdown
Author

Thank you @Khantdotcom for your valuable comments and suggestions I wasn't a ware that the PR was reviewed until today as the label was pointing to needs review. I have made a commit and I hope that would solve the outstanding quests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Khantdotcom Khantdotcom Khantdotcom requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ebrahim-Moqbel @Khantdotcom